https://bugzilla.redhat.com/show_bug.cgi?id=957934 Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jamielinux@xxxxxxxxxxxxxxxx | |g Assignee|nobody@xxxxxxxxxxxxxxxxx |jamielinux@xxxxxxxxxxxxxxxx | |g Flags| |fedora-review? --- Comment #1 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines Error: Package: nodejs-tilelive-4.4.3-1.fc18.noarch (/nodejs-tilelive-4.4.3-1.fc18.noarch) Requires: npm(optimist) < 0.4 Installing: nodejs-optimist-0.4.0-1.fc18.noarch (updates) npm(optimist) = 0.4.0 Versioned dependency on optimist needs to be fixed. Also, I see you used a patch for the underscore dependency, I assume because nodejs_fixdep wasn't available yet at the time of making this package. - nodejs-tilelive.noarch: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end - nodejs-tilelive.noarch: W: spelling-error Summary(en_US) backends -> back ends, back-ends, backhands Might be tempted to hyphenate these, just to keep rpmlint happy, but up to you. [!]: Package functions as described. I think line 41 needs to be fixed: ln -sf %{nodejs_sitelib}/bin/copy %{buildroot}/%{_bindir}/tilelive-copy Should look like this: ln -sf %{nodejs_sitelib}/tilelive/bin/copy %{buildroot}/%{_bindir}/tilelive-copy ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 1.1.32 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.32 INFO: Mock Version: 1.1.32 Start: lock buildroot INFO: installing package(s): /home/mockbuild/review/nodejs-tilelive/results/nodejs-tilelive-4.4.3-1.fc18.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/data/mock/fedora-18-x86_64/root/', 'install', '/home/mockbuild/review/nodejs-tilelive/results/nodejs-tilelive-4.4.3-1.fc18.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: nodejs-tilelive-4.4.3-1.fc18.noarch (/nodejs-tilelive-4.4.3-1.fc18.noarch) Requires: npm(optimist) < 0.4 Installing: nodejs-optimist-0.4.0-1.fc18.noarch (updates) npm(optimist) = 0.4.0 You could try using --skip-broken to work around the problem Error: Package: nodejs-tilelive-4.4.3-1.fc18.noarch (/nodejs-tilelive-4.4.3-1.fc18.noarch) Requires: npm(optimist) < 0.4 Available: nodejs-optimist-0.4.0-1.fc18.noarch (updates) npm(optimist) = 0.4.0 You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: nodejs-tilelive-4.4.3-1.fc18.noarch.rpm nodejs-tilelive.noarch: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end nodejs-tilelive.noarch: W: spelling-error Summary(en_US) backends -> back ends, back-ends, backhands nodejs-tilelive.noarch: W: spelling-error Summary(en_US) mapnik -> manikin nodejs-tilelive.noarch: W: spelling-error Summary(en_US) mbtiles -> motiles, tiles nodejs-tilelive.noarch: W: spelling-error %description -l en_US tilestore -> tile store, tile-store, tiles tore nodejs-tilelive.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-tilelive.noarch: W: only-non-binary-in-usr-lib nodejs-tilelive.noarch: W: dangling-symlink /usr/lib/node_modules/tilelive/node_modules/step /usr/lib/node_modules/step nodejs-tilelive.noarch: W: dangling-symlink /usr/lib/node_modules/tilelive/node_modules/optimist /usr/lib/node_modules/optimist nodejs-tilelive.noarch: W: dangling-symlink /usr/lib/node_modules/tilelive/node_modules/underscore /usr/lib/node_modules/underscore nodejs-tilelive.noarch: W: dangling-symlink /usr/bin/tilelive-copy /usr/lib/node_modules/bin/copy nodejs-tilelive.noarch: W: dangling-symlink /usr/lib/node_modules/tilelive/node_modules/sphericalmercator /usr/lib/node_modules/sphericalmercator nodejs-tilelive.noarch: W: no-manual-page-for-binary tilelive-copy 1 packages and 0 specfiles checked; 0 errors, 13 warnings. Requires -------- nodejs-tilelive (rpmlib, GLIBC filtered): /usr/bin/env nodejs(engine) npm(optimist) npm(sphericalmercator) npm(step) npm(underscore) Provides -------- nodejs-tilelive: nodejs-tilelive npm(tilelive) Source checksums ---------------- http://registry.npmjs.org/tilelive/-/tilelive-4.4.3.tgz : CHECKSUM(SHA256) this package : 54fad31afd5a3d2267359ec2d9160072c3367d17b10e12e69e5361bea1d8b0f1 CHECKSUM(SHA256) upstream package : 54fad31afd5a3d2267359ec2d9160072c3367d17b10e12e69e5361bea1d8b0f1 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-18-x86_64 Command line :/bin/fedora-review -r -n nodejs-tilelive-4.4.3-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jjTVtkw6KC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review