https://bugzilla.redhat.com/show_bug.cgi?id=916797 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #12 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5423958 $ rpmlint mingw-glew.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-glew-1.9.0-4.fc20.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-glew-1.9.0-4.fc19.noarch.rpm mingw32-glew-static-1.9.0-4.fc19.noarch.rpm mingw32-glew-tools-1.9.0-4.fc19.noarch.rpm mingw64-glew-1.9.0-4.fc19.noarch.rpm mingw64-glew-static-1.9.0-4.fc19.noarch.rpm mingw64-glew-tools-1.9.0-4.fc19.noarch.rpm mingw32-glew-static.noarch: W: no-documentation mingw32-glew-tools.noarch: W: no-documentation mingw64-glew-static.noarch: W: no-documentation mingw64-glew-tools.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpm --query --requires mingw32-glew rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 83 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(msvcrt.dll) mingw32(opengl32.dll) mingw32-pkg-config rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-glew rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 83 mingw64(kernel32.dll) mingw64(msvcrt.dll) mingw64(opengl32.dll) mingw64-pkg-config rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-glew-static mingw32-glew = 1.9.0-4.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-glew-static mingw64-glew = 1.9.0-4.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-glew-tools mingw32-glew = 1.9.0-4.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 83 mingw32(gdi32.dll) mingw32(glew32.dll) mingw32(kernel32.dll) mingw32(msvcrt.dll) mingw32(opengl32.dll) mingw32(user32.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-glew-tools mingw64-glew = 1.9.0-4.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 83 mingw64(gdi32.dll) mingw64(glew32.dll) mingw64(kernel32.dll) mingw64(msvcrt.dll) mingw64(opengl32.dll) mingw64(user32.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-glew mingw32-glew = 1.9.0-4.fc19 mingw32(glew32.dll) mingw32(glew32mx.dll) $ rpm --query --provides mingw64-glew mingw64-glew = 1.9.0-4.fc19 mingw64(glew32.dll) mingw64(glew32mx.dll) $ rpm --query --provides mingw32-glew-static mingw32-glew-static = 1.9.0-4.fc19 $ rpm --query --provides mingw64-glew-static mingw64-glew-static = 1.9.0-4.fc19 $ rpm --query --provides mingw32-glew-tools mingw32-glew-tools = 1.9.0-4.fc19 $ rpm --query --provides mingw64-glew-tools mingw64-glew-tools = 1.9.0-4.fc19 $ wget --quiet http://downloads.sourceforge.net/glew/glew-1.9.0.tgz -O - | md5sum 69ce911decef6249d24742497e6ad06a - $ md5sum glew-1.9.0.tgz 69ce911decef6249d24742497e6ad06a glew-1.9.0.tgz + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [!] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [!] Uses the macro %mingw_make to build the package [!] Uses the macro %mingw_make to install the package [+] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [!] Requires of the binary mingw32 and mingw64 packages are equal The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64 package doesn't. I've also seen this on various other packages so we can ignore this for now This package doesn't use any of the configure and make-related mingw macros. Normally this is a blocker, but given the fact that upstream of this package uses hand-written Makefiles (instead of a generic build system like autotools) I'm okay with the way the package is built in the current .spec file. ================================================ The package mingw-glew is APPROVED by epienbro ================================================ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t6AKubB6KS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review