Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: nfs-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226198 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-03-09 16:25 EST ------- I saw a few updates come over CVS so I decided to try again. It's building fine for me now, so I can move forward with a review. W: nfs-utils summary-ended-with-dot NFS utilities and supporting clients and daemons for the kernel NFS server. Trivial to fix. E: nfs-utils tag-not-utf8 %changelog E: nfs-utils non-utf8-spec-file nfs-utils.spec Due to Trond's name way back in the changelog; a pass through iconv will fix it up. W: nfs-utils macro-in-%changelog pre Just an errant unescaped percent sign. W: nfs-utils no-url-tag Probably should point to nfs.sourceforge.net W: nfs-utils strange-permission nfs.init 0755 W: nfs-utils strange-permission rpcgssd.init 0755 W: nfs-utils strange-permission nfslock.init 0755 W: nfs-utils strange-permission rpcsvcgssd.init 0755 W: nfs-utils strange-permission rpcidmapd.init 0755 rpmlint complains about executable files in the SRPM; I don't think it's a big issue as long as the permissions are sane. W: nfs-utils unversioned-explicit-obsoletes nfs-server W: nfs-utils unversioned-explicit-obsoletes knfsd W: nfs-utils unversioned-explicit-obsoletes knfsd-clients W: nfs-utils unversioned-explicit-obsoletes nfs-server-clients W: nfs-utils unversioned-explicit-obsoletes knfsd-lock W: nfs-utils unversioned-explicit-provides nfs-server W: nfs-utils unversioned-explicit-provides nfs-server-clients W: nfs-utils unversioned-explicit-provides knfsd-lock W: nfs-utils unversioned-explicit-provides knfsd-clients W: nfs-utils unversioned-explicit-provides knfsd These are problematic. They always need to be versioned, but there's also no reason to worry about providing an upgrade path for packages which haven't existed in the past two Fedora releases. I don't even see those packages back in the RHL days, the obsoletes/provides bits were present in the initial CVS import of this spec, so I think it's quite safe to say that the obsoletes should just go. The provides should go if nothing depends on them, and as far as I can tell (by running repoquery --whatrequires) nothing does. W: nfs-utils buildprereq-use nfs-utils-lib-devel libevent-devel libgssapi-devel These should either turn into BuildRequires or go away. It turns out they're already in BuildRequires; W: nfs-utils prereq-use shadow-utils >= 4.0.3-25 W: nfs-utils prereq-use /sbin/chkconfig /sbin/nologin W: nfs-utils prereq-use nfs-utils-lib >= 1.0.8-2 libevent libgssapi Prereq is pretty much meaningless and needs to be replaced with fine-grained dependencies like Requires(pre) W: nfs-utils rpm-buildroot-usage %build --prefix=$RPM_BUILD_ROOT \ I'll have to look deeper to see what's up here. W: nfs-utils mixed-use-of-spaces-and-tabs (spaces: line 192, tab: line 139) Just rpmlint being picky. I've run out of time at the moment; more rpmlint complaints later. I'll also be submitting a patch to fix most of these up. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review