https://bugzilla.redhat.com/show_bug.cgi?id=966732 Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #2 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> --- Review based on fedora-review tool and manual steps. [OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. Rpmlint ------- Checking: mailman3-fedmsg-plugin-0.1.1-1.fc18.noarch.rpm mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US cfg -> cf, cg, cog mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US archiver -> archive, archives, archived mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US Archiver -> Archive, Archives, Archived mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US bugzilla -> Bugzilla 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mailman3-fedmsg-plugin mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US cfg -> cf, cg, cog mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US archiver -> archive, archives, archived mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US Archiver -> Archive, Archives, Archived mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure mailman3-fedmsg-plugin.noarch: W: spelling-error %description -l en_US bugzilla -> Bugzilla Above warnings can be ignored. [OK] MUST: The package must be named according to the Package Naming Guidelines [OK] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [OK] MUST: The package must meet the Packaging Guidelines [OK] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [OK] MUST: The License field in the package spec file must match the actual license. [OK] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [OK] MUST: The spec file must be written in American English. [OK] MUST: The spec file for the package MUST be legible. [OK] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. Source checksums ---------------- http://pypi.python.org/packages/source/m/mailman3-fedmsg-plugin/mailman3-fedmsg-plugin-0.1.1.tar.gz : CHECKSUM(SHA256) this package : c7dde6ff19603308a9fa0bd44bd1e06af8c3e3b01868ec456c88e86e89c2f783 CHECKSUM(SHA256) upstream package : c7dde6ff19603308a9fa0bd44bd1e06af8c3e3b01868ec456c88e86e89c2f783 [OK] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [OK] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [OK] MUST: Packages must NOT bundle copies of system libraries [OK] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] [OK] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [OK] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [ [OK] MUST: Each package must consistently use macros. [OK] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [OK] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] [OK] MUST: All filenames in rpm packages must be valid UTF-8. [OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec file [OK] SHOULD: Sources can be downloaded from URI in Source: tag [OK] SHOULD: Reviewer should test that the package builds in mock. [OK] SHOULD: Buildroot is not present [OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [OK] SHOULD: Dist tag is present. [OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [OK] SHOULD: SourceX tarball generation or download is documented. [OK] SHOULD: SourceX is a working URL. [OK] SHOULD: Spec use %global instead of %define. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OQzf7y8oHc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review