https://bugzilla.redhat.com/show_bug.cgi?id=883413 Adrien Devresse <adev88@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Adrien Devresse <adev88@xxxxxxxxx> --- just two minor comments before the formal review : - the directory ownership of %{_javadocdir}/%{srcname} is not set with %dir - It's usually clearer to use one style of the macro ( $RPM_BUILD_ROOT or %{buildroot} ) but not both if possible. Adrien -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0RLsddxjgU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review