[Bug 962189] Review Request: cego - A relational and transactional database

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=962189

--- Comment #14 from Björn Esser <bjoern.esser@xxxxxxxxx> ---
* fedora-review shows:

warning: bogus date in %changelog: Wed May 23 2013 Christopher Meng
<rpm@xxxxxxxx> - 2.18.6-1

--> Thu May 23

* in spec:

BuildRequires:     lfcbase-devel%{?_isa}
BuildRequires:     lfcxml-devel%{?_isa}

--> you must NOT use %{?_isa} in BuildRequires, because these will be the
"Requires" of the produced SRPM. SRPM must not have Requires on fixed arch. If
you have such in your specs on SCM as well, fix them, rebuild and resubmit to
obsolete older release, please.
Don't forget to add Requires: lfcbase-devel%{?_isa} to the lfcxml-devel for
reason explained/clarified in #12.

You can drop the (Build)Requires on lfcbase-devel in spec of this pkg after
fixing lfcxml, then.

* sed-magic doesn't seem to work on binary-or-shlib-defines-rpath:

cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgblow ['/usr/lib64']
cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cego ['/usr/lib64']
cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgadm ['/usr/lib64']
cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cglog ['/usr/lib64']
cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgclt ['/usr/lib64']

--> Consider using `chrpath` as a last resort:

BuildRequires: chrpath

after install:

for _rpbin in $RPM_BUILD_ROOT%{_bindir}/*
do
  chrpath --delete "${_rpbin}"
done

* sed-magic doesn't seem to work on unused-direct-shlib-dependency:

cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/libcrypt.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/librt.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/libpthread.so.0
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/libnsl.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/libreadline.so.6
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/libhistory.so.6
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0
/lib64/libm.so.6
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libcrypt.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/librt.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libpthread.so.0
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libnsl.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libncurses.so.5
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libtinfo.so.5
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libreadline.so.6
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libhistory.so.6
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/liblfcxml.so.1
cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0
/lib64/libm.so.6

--> There's something _really wrong_ with configure.ac and/or Makefile.am.
Are you familiar with autotool's meta-files-syntax or shall I workout a solving
patch on them? Let's discuss this on PM.

Please fix the above in spec (patch not needed instantly) and I'll give it
another shot ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y5kYCslQgs&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]