https://bugzilla.redhat.com/show_bug.cgi?id=821146 --- Comment #13 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Gil, I'm still wondering, why don't you package it just as a gem (see comment #4). What is the point of keeping the maven stuff and -javadoc subpackages around? They are not distributed with the gem version as far as I understand. I would like to see this package renamed to "rubygem-jruby-rack" and that is it. Is that some Java standard? Should we clarify this with Java-SIG? Moreover, you should install the gem into standard Fedora's gem locations IMO, using standard gem macros. The "%{_datadir}/jruby/lib/ruby/gems/1.8/gems/" was never intended to be used on Fedora. I am not sure if that location even works (but you probably tested it, so we might want to disable it, to prevent its misuse). Also, I am not Java, JRuby nor Rack expert, but I would say, that you have overspecified requires. From my POV, the gem should depend just on "ruby(rubygems)" and nothing else and the reasoning is following: I have installed MRI and I do "yum install rubygem-jruby-rack". After that, I can do: $ irb irb(main):001:0> p RUBY_DESCRIPTION "ruby 2.0.0p0 (2013-02-24) [x86_64-linux]" => "ruby 2.0.0p0 (2013-02-24) [x86_64-linux]" irb(main):002:0> require 'jruby-rack' => true irb(main):003:0> p JRuby::Rack::VERSION "1.1.13.2" => "1.1.13.2" and you see, it "works". It can be required. From the code, I would say that this is design decision of upstream. So why you would force me to install all the dependencies you have listed in the .spec file right now? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EM3f3qPdoZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review