[Bug 963077] Review Request: brise - the official Rime schema repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=963077

--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build succeeded for rawhide

+ rpmlint on rpms gave
brise.src: W: summary-not-capitalized C the official Rime schema repository
brise.src: W: invalid-url Source0:
http://rimeime.googlecode.com/files/brise-0.22.tar.gz HTTP Error 404: Not Found
brise.x86_64: W: summary-not-capitalized C the official Rime schema repository
brise.x86_64: E: no-binary
brise-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 3 warnings.
==> sourcecode warning can be ignored here

+ Source verified with upstream as
http://rimeime.googlecode.com/files/brise-0.22.tar.gz :
  CHECKSUM(SHA256) this package     :
a048b741a7651dbb47d1b6e6e25d266d670680112b70ca3c27f2bc17dcafde59
  CHECKSUM(SHA256) upstream package :
a048b741a7651dbb47d1b6e6e25d266d670680112b70ca3c27f2bc17dcafde59

+ package follows packaging guidelines

Suggestions:
1) Should this be noarch package? if not then you can disable debuginfo package 
 with "%global debug_package %{nil}" at the beginning of the spec.

2) Please fix the issues raised in above comments.

3) you can also ChangeLog AUTHORS add to %doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8DHKXOaL13&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]