https://bugzilla.redhat.com/show_bug.cgi?id=964437 greg.hellings@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |greg.hellings@xxxxxxxxx --- Comment #3 from greg.hellings@xxxxxxxxx --- The error about not using parallel make is because you think you are, but you're not. You have %{mingw_make} %{?_smp_flags} It should be %{mingw_make} %{?_smp_mflags} I'm curious as to why you're manually installing what seems to be all of the generated files. That doesn't seem right. I also don't think we do Desktop files in MinGW. You should include, at the least, any license files as %doc arguments in MinGW packages. However, other documentation that is present in a native package (e.g. man pages, etc) is not to be in MinGW. As such you can probably leave off the doxygen invocation during build. I also don't believe we like to keep around all the past Changelog when we create a new port to MinGW. At least I don't keep it lying around. This is not an official review, just some notes I see while looking through your Spec file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6W0PT0SwVt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review