https://bugzilla.redhat.com/show_bug.cgi?id=962189 --- Comment #7 from Björn Esser <bjoern.esser@xxxxxxxxx> --- So first review-build revealed serveral rpmlint issues: * binary-or-shlib-defines-rpath --> upstream should fix this As a temporary solution on of these should fix: http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath * undefined-non-weak-symbol --> another one for upstream to fix I'd not consider this a BLOCKER ;) * unused-direct-shlib-dependency --> some sed-magic like used in lfcbase/lfcxml should do the trick. * incorrect-fsf-address --> upstream should update sources... In spec-file: * License: GPLv2 --> upstream changed to GPLv3+ * -devel Requires: lfcbase-devel%{?_isa} lfcxml-devel%{?_isa} headers have includes on some pkg'ed in the mentioned. I will start another run after you updated spec/srpm. Rpmlint ------- Checking: cego-2.18.4-1.fc20.x86_64.rpm cego-devel-2.18.4-1.fc20.x86_64.rpm cego.x86_64: W: spelling-error Summary(en_US) transactional -> transaction, transnational, transitional cego.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgblow ['/usr/lib64'] cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cego ['/usr/lib64'] cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgadm ['/usr/lib64'] cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cglog ['/usr/lib64'] cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgclt ['/usr/lib64'] cego.x86_64: W: no-manual-page-for-binary cgblow cego.x86_64: W: no-manual-page-for-binary cego cego.x86_64: W: no-manual-page-for-binary cgclt cego.x86_64: W: no-manual-page-for-binary cglog cego.x86_64: W: no-manual-page-for-binary cgadm cego-devel.x86_64: W: no-documentation cego-devel.x86_64: E: incorrect-fsf-address /usr/include/cego/CegoAdmNet.h cego-devel.x86_64: E: incorrect-fsf-address /usr/include/cego/CegoNet.h 2 packages and 0 specfiles checked; 7 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint cego cego-devel cego.x86_64: W: spelling-error Summary(en_US) transactional -> transaction, transnational, transitional cego.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgblow ['/usr/lib64'] cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/libcrypt.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/librt.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/libpthread.so.0 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/libnsl.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/libreadline.so.6 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/libhistory.so.6 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcego.so.1.0.0 /lib64/libm.so.6 cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cego ['/usr/lib64'] cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgadm ['/usr/lib64'] cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoModule::getModId(Chain const&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoProcVar::CegoProcVar(Chain const&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoField::getAttrName() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoFieldValue::getValue() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoModule::getModName(int) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::~CegoDbHandler() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoProcVar::operator==(CegoProcVar const&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::getMsg() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::abortQuery() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::putBlob(Chain const&, CegoBlob&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::reqQueryOp(Chain const&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoFieldValue::getType() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoModule::CegoModule(Chain const&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoProcVar::~CegoProcVar() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoModule::~CegoModule() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoField::~CegoField() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::getFileId() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::allocate(long) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::resetQuery() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::nextChunk(long) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::CegoBlob(int, int) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoFieldValue::valAsChain(bool) const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoField::CegoField() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoFieldValue::CegoFieldValue() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::getSchema() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::CegoBlob() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::getProcResult(ListT<CegoProcVar>&, CegoFieldValue&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoField::operator=(CegoField const&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoFieldValue::~CegoFieldValue() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoProcVar::getValue() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::CegoDbHandler(NetHandler*, CegoDbHandler::ProtocolType, CegoModule*) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::~CegoBlob() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::getBlob(Chain const&, CegoBlob&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::getPageId() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::reset() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::requestSession(Chain const&, Chain const&, Chain const&, bool) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoModule::getMapSize() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::getSize() const cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::getChunkPtr() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoBlob::putChunk(unsigned char*, long) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::delBlob(Chain const&, CegoBlob&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::closeSession() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoModule::CegoModule() cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::receiveTableData(ListT<CegoField> const&, ListT<CegoFieldValue>&) cego.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcgwrap.so.1.0.0 CegoDbHandler::getTableSet() cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libcrypt.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/librt.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libpthread.so.0 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libnsl.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libncurses.so.5 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libtinfo.so.5 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libreadline.so.6 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libhistory.so.6 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/liblfcxml.so.1 cego.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcgwrap.so.1.0.0 /lib64/libm.so.6 cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cglog ['/usr/lib64'] cego.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/cgclt ['/usr/lib64'] cego.x86_64: W: no-manual-page-for-binary cgblow cego.x86_64: W: no-manual-page-for-binary cego cego.x86_64: W: no-manual-page-for-binary cgclt cego.x86_64: W: no-manual-page-for-binary cglog cego.x86_64: W: no-manual-page-for-binary cgadm cego-devel.x86_64: W: no-documentation cego-devel.x86_64: E: incorrect-fsf-address /usr/include/cego/CegoAdmNet.h cego-devel.x86_64: E: incorrect-fsf-address /usr/include/cego/CegoNet.h 2 packages and 0 specfiles checked; 7 errors, 70 warnings. # echo 'rpmlint-done:' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6xTMbXnH2I&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review