https://bugzilla.redhat.com/show_bug.cgi?id=965344 Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #2 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> --- Package review based on manual steps and fedora-review tool. [OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. Rpmlint ------- Checking: rasdaemon-0.3.0-1.fc18.x86_64.rpm rasdaemon.x86_64: W: spelling-error %description -l en_US chipsets -> chip sets, chip-sets, Chiclets rasdaemon.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace rasdaemon.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit rasdaemon.x86_64: W: spelling-error %description -l en_US startup -> start up, start-up, upstart rasdaemon.x86_64: W: spelling-error %description -l en_US sysfs -> sysops rasdaemon.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rasdaemon rasdaemon.x86_64: W: spelling-error %description -l en_US chipsets -> chip sets, chip-sets, Chiclets rasdaemon.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace rasdaemon.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit rasdaemon.x86_64: W: spelling-error %description -l en_US startup -> start up, start-up, upstart rasdaemon.x86_64: W: spelling-error %description -l en_US sysfs -> sysops rasdaemon.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 6 warnings. # echo 'rpmlint-done:' All warnings can be ignored. [OK] MUST: The package must be named according to the Package Naming Guidelines [OK] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [OK] MUST: The package must meet the Packaging Guidelines . [OK] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [OK] MUST: The License field in the package spec file must match the actual license. [3] [OK] MUST: The spec file must be written in American English. [OK] MUST: The spec file for the package MUST be legible. [OK] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. >From src.rpm: 87eb4e0a518b6f38fa368bba24d64637939281820d6b0c49084345a2ba8b10d9 rasdaemon-0.3.0.tar.bz2 >From url: 87eb4e0a518b6f38fa368bba24d64637939281820d6b0c49084345a2ba8b10d9 rasdaemon-0.3.0.tar.bz2 [OK] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [OK] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [OK] MUST: Packages must NOT bundle copies of system libraries. [OK] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] [OK] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] [OK] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15] [OK] MUST: Each package must consistently use macros. [16] [OK] MUST: The package must contain code, or permissable content. [17] [OK[ MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] [OK] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [OK] MUST: All filenames in rpm packages must be valid UTF-8 [OK] SHOULD: The reviewer should test that the package builds in mock [OK] SHOULD: The package should compile and build into binary rpms on all supported architectures. [OK] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l2K5OEXE1b&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review