https://bugzilla.redhat.com/show_bug.cgi?id=947071 --- Comment #16 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- (In reply to Christopher Meng from comment #15) > Hi Robin, > > 1)Upstream provide a not good system unit file IMO, and logrotate file also. Since upstream provides equivalent files, you should provide patches instead of replacing files. And then patches must be sent upstream and each come with a comment in the specfile. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > 3)I don't know if I create the sub packages I should Add Requires for httpd > or lighthttpd? I don't fill splitting sub-packages is a necessary and perfect enhancement for this package. Just go ahead with other issues. After all, you must check the [!] items in the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NeiqZcgwuF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review