https://bugzilla.redhat.com/show_bug.cgi?id=956669 --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Antonio Trande from comment #2) > Hi Christopher. > Just some initial comments: > > - I see some changes about FHS fixes. In my opinion, with a single > modification into 'deployment.pri' file, you can resolve all at one time ;) Thanks! I'm not familiar with Qt, now I remember this~ > - .desktop file is already in the source archive; why do you add another one > as Source1 ? Its bundled desktop file is invalid and doesn't match Fedora's standard, I think rewriting one is better than patching. > - %{_datadir}/%{name} directory must be owned by the package You mean I should remove the asterisk? > - In erebus_source.txt file, the developer says: > > >The source code is released under the GPL v3 or later. > >Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com . > > I don't see any license file included, apart from docs/gpl.txt file that is > not the GPLv3+ text file. Ok, I've mailed the author, hope he can fix that. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jQkpXGRuJd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review