https://bugzilla.redhat.com/show_bug.cgi?id=924377 --- Comment #10 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- (In reply to Hans de Goede from comment #9) > Full review done, results: <snip> > Needs work: > ======== > - You're using an upstream tarbal, so there should be no need to run > autogen.sh, if there is a specific reason for this, please add a comment to > the specfile why you're running autogen.sh. Note that %configure has been > modified in newer redhat-rpm-config versions to take care of aarch64 issues, > so if that is the reason you can drop the autogen.sh call. > - desktop-file-validate is usually called from %install, %check is intended > for packages with come with test-suites to run the test-suite. ie make test > / make check Thanks for your hints. I will removed %check and use %install for desktop-file-validate. All current MATE tarballs comes without configure and make files, they have only configure.ac/in and Makefile.am include. For this reason i use NOCONFIGURE=1 ./autogen.sh to create them. New mock build: * Mon May 20 2013 Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> - 1.6.0-3 - remove %%check - add a comment for usage of autogen.sh Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-user-share.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-user-share-1.6.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k5Q20DBUyb&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review