Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962813 --- Comment #2 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, (In reply to comment #1) > Hi Hans, > you didn't assign a review from me Yes, I didn't get around to doing one yet, will do so ASAP. any particular review you would prefer me to take? > anyway i start working on yours. Thanks! > I general your package looks good, but i've one questions. > > Issues: > ======= > - update-desktop-database is invoked when required > Note: desktop file(s) in funguloids > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > faults positiv in every current review at the moment. Calling update-desktop-database is only needed when desktop files include mime-types, which most don't. If there is no MimeType=... in the .desktop file update-desktop-file is not needed. > > ===== EXTRA items ===== > > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > Note: Arch-ed rpms have a total of 20664320 bytes in /usr/share 20664320 > funguloids-1.06-1.fc20.x86_64.rpm > > I'm not shure if this is fixable, because your package doesn't use /{libdir} > , but it isn't noarch. > So i'm thinking, /usr/share/funguloids (20.3 MB) contains libaries for the > package. > Or did the package work if you move this directory to a noarch subpackage? Moving the data to a noarhx sub-package is certainly doable, but not really necessary. 20 MB is not really all that large large is say 100_ MB, otherwise we would need to split tons and tons of packages. Usually in cases where we do a split-off -data package, upstream also has the data in a separate tarbal, and then splitting makes a lot of sense. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FEwqgFoWNM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review