Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947071 --- Comment #14 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Package must own all directories that it creates. Note: Some directories are not owned: /usr/lib/%{name}/ %{_localstatedir}/lib/%{name}/ %{_localstatedir}/lib/%{name}/reports/ %{_datadir}/%{name}/ %{_datadir}/%{name}/cgi/ [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. Note: * No need to explicitly require rrdtool * Requires perl(HTTP::Server::Simple) is false, it actually uses perl(HTTP::Server::Simple::CGI) which has been added to Requires by rpmbuild automatically. * Requires perl(DBD::mysql) is needed in mysql.pm, just Requires perl(DBI) is not enough [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. [!]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: missed BuildRequires perl [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). Note: The Perl modules provided should be filtered. The Requires perl(Monitorix) and perl(HTTPServer) should be filtered. https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: monitorix-3.2.0-1.fc18.noarch.rpm monitorix.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint monitorix monitorix.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- monitorix (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl config(monitorix) logrotate perl perl(:MODULE_COMPAT_5.16.3) perl(CGI) perl(Config::General) perl(Cwd) perl(DBI) perl(Exporter) perl(File::Basename) perl(FindBin) perl(Getopt::Std) perl(HTTP::Server::Simple) perl(HTTP::Server::Simple::CGI) perl(HTTPServer) perl(LWP::UserAgent) perl(MIME::Lite) perl(Monitorix) perl(POSIX) perl(RRDs) perl(Socket) perl(XML::Simple) perl(base) perl(constant) perl(lib) perl(strict) perl(warnings) rrdtool systemd Provides -------- monitorix: config(monitorix) monitorix perl(HTTPServer) perl(Monitorix) perl(apache) perl(bind) perl(disk) perl(fail2ban) perl(fs) perl(ftp) perl(hptemp) perl(icecast) perl(int) perl(kern) perl(lighttpd) perl(lmsens) perl(mail) perl(mysql) perl(net) perl(nfsc) perl(nfss) perl(nginx) perl(ntp) perl(nvidia) perl(port) perl(proc) perl(raspberrypi) perl(serv) perl(squid) perl(system) perl(traffacct) perl(user) Source checksums ---------------- http://www.monitorix.org/monitorix-3.2.0.tar.gz : CHECKSUM(SHA256) this package : 512a145431aba68a59f79e75e9d8400f878c5b6050c03be5c5542f6590e3d1d0 CHECKSUM(SHA256) upstream package : 512a145431aba68a59f79e75e9d8400f878c5b6050c03be5c5542f6590e3d1d0 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -b 947071 ===== Manual review items ===== * Use upstream provided systemd unit file and logrotate file in docs/ * Patch shebang with stricter regex: sed -i 's|#!/usr/bin/env perl|#!/usr/bin/perl|' monitorix * Consider packaging Apache and Lighttpd config files in sub-packages, follow the way like the package 'anyterm' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f5wBTfDB27&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review