Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=804125 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #7 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Just a few initial comments: BuildRequires: python-devel This is deprecated, you have to require python2-devel: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires Regarding the runtime requirements of the subpackages, first have a look what rpm pulls automatically before adding some things there by hand. I'm quite sure that the -devel package will get the python2-devel dependency anyway. Requires: %{name} = %{version}-%{release} For arch-dependent packages, we need a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} Don't mix %{buildroot} and $RPM_BUILD_ROOT in the same spec file. %defattr(-,root,root,-) This line is obsolete, even for EPEL-5 packages, although rpmlint doesn't say so. Please remove unneeded parts from the file header (the line regarding python_sitelib). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HOpmA5c2Bl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review