[Bug 959974] Review Request: liblfc - Lemke Foundation Classes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=959974

--- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to comment #2)
> possible name-collision:
> Consider asking upstream having the lib renamed, eg. liblemkefc or
> liblemke-base (since it is the baselib for all FOSS on lemke-it.com...)

Aha..In fact upstream has changed the name to liblfcbase(How can you guess it!)

> rpmlint (for srpm):
> 
> liblfc.src: W: spelling-error Summary(en_US) Lemke -> Lepke, Lemme // ignored
> liblfc.src:46: E: hardcoded-library-path in /usr/lib/*.so.*
> liblfc.src:51: E: hardcoded-library-path in /usr/lib/*.so
> liblfc.src:22: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 22)
> liblfc.src: W: file-size-mismatch lfc-1.5.2.tar.gz = 1032882,
> http://www.lemke-it.com/lfc-1.5.2.tar.gz = 1032866 (!?!)
> 
> mock-build exhibits error (as promised by rpmlint):
> 
> File not found by "glob":
> /builddir/build/BUILDROOT/liblfc-1.5.2-1.fc20.x86_64/usr/lib/*.so.*
> 
> in spec-file:
> 
> %files
> %doc COPYING
> /usr/lib/*.so.* --> why you not use %{_libdir}/*.so.* ???
> 
> same goes for -devel.

I know these problems at all. In fact Upstream has released at least 10 version
recently just because of this review. Prior to that upstream doesn't use Linux
to develope the program, as a result many things thorny has happened. So I stop
revising the spec until coming to stable.

These problems will be fixed later(upstream just released a new version 30
minutes ago...)

> Consider adding samples/*.cc to -devel %doc to give a "basic" idea how this
> lib can be useful.

Maybe.

> BTW: Upstream sources does not provide a way to create some useful docs
> (e.g. using doxygen). How shall one make use of this lib, if you don't know
> how to use without studying sources???

These libs are not for study in fact. Just a base classes for lemke products
like cego or etc...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FFS3T3krA7&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]