Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963197 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Mozilla-PublicSuffix.spec.old 2013-05-15 13:21:25.000000000 +0200 +++ perl-Mozilla-PublicSuffix.spec 2013-05-16 23:23:22.000000000 +0200 @@ -1,13 +1,14 @@ -%global publicsuffix_date 20130515 +%global publicsuffix_date 20130516 Name: perl-Mozilla-PublicSuffix Version: 0.1.13 -Release: 1.%{publicsuffix_date}%{?dist} +Release: 2.%{publicsuffix_date}%{?dist} Summary: Get a domain name's public suffix via the Mozilla Public Suffix List License: MIT Group: Development/Libraries URL: http://search.cpan.org/dist/Mozilla-PublicSuffix/ Source0: http://www.cpan.org/authors/id/R/RS/RSIMOES/Mozilla-PublicSuffix-v%{version}.tar.gz +# http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/effective_tld_names.dat?raw=1 Source1: effective_tld_names.dat BuildArch: noarch @@ -16,25 +17,28 @@ BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) BuildRequires: perl(URI::_idna) +BuildRequires: perl(HTTP::Tiny) +BuildRequires: perl(Tie::File) +BuildRequires: perl(Exporter) + Requires: perl(URI::_idna) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description This module provides a single function that returns the public suffix of a domain name by referencing a parsed copy of Mozilla's Public Suffix List. -From the official website at http://publicsuffix.org +From the official website at http://publicsuffix.org/ %prep %setup -q -n Mozilla-PublicSuffix-v%{version} cp -a %{SOURCE1} ./ %build -%{__perl} Build.PL installdirs=vendor </dev/null +perl Build.PL installdirs=vendor </dev/null ./Build %install ./Build install destdir=$RPM_BUILD_ROOT create_packlist=0 -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} $RPM_BUILD_ROOT/* @@ -42,10 +46,13 @@ ./Build test %files -%doc Changes dist.ini effective_tld_names.dat LICENSE perlcritic.rc README +%doc Changes effective_tld_names.dat LICENSE README %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Thu May 16 2013 Yanko Kaneti <yaneti@xxxxxxxxxxx> 0.1.13-2.20130516 +- Address review comments (#963197#1) + * Wed May 15 2013 Yanko Kaneti <yaneti@xxxxxxxxxxx> 0.1.13-1.20130515 - Specfile autogenerated by cpanspec 1.78 and modified for review > TODO: Append trailing slash to the URL. HTTP URL has mandatory path part. -From the official website at http://publicsuffix.org +From the official website at http://publicsuffix.org/ Ok. > TODO: Do not package dist.ini and perlcritic.rc files. There are no unique data > usable for a user. -%doc Changes dist.ini effective_tld_names.dat LICENSE perlcritic.rc README +%doc Changes effective_tld_names.dat LICENSE README Ok. > TODO: Comment source of the overlay effective_tld_names.dat file (Source1). +# http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/effective_tld_names.dat?raw=1 Ok. > TODO: You can use plain `perl' command instead of `%{__perl}' macro. -%{__perl} Build.PL installdirs=vendor </dev/null +perl Build.PL installdirs=vendor </dev/null Ok. TODO: The same applies to perl(:MODULE_COMPAT definition. > TODO: You can remove deleting empty directories from %install section. -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > FIX: Build-require `perl(HTTP::Tiny)' (Build.PL:7). +BuildRequires: perl(HTTP::Tiny) Ok. > TODO: Build-require `perl(Tie::File)' (Build.PL:9). +BuildRequires: perl(Tie::File) Ok. > FIX: Build-require `perl(Exporter)' (lib/Mozilla/PublicSuffix.pm:6). +BuildRequires: perl(Exporter) Ok. > FIX: Build-require `perl(File::Temp)' (t/00-compile.t:11). Ok. $ rpmlint perl-Mozilla-PublicSuffix.spec ../SRPMS/perl-Mozilla-PublicSuffix-0.1.13-2.20130516.fc20.src.rpm ../RPMS/noarch/perl-Mozilla-PublicSuffix-0.1.13-2.20130516.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5391099). Ok Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M77enpf2Lq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review