[Bug 961141] Review Request: debhelper - Helper programs for debian/rules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=961141

--- Comment #21 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> ---
Hi, before review , lets fixes things and see you agree ...
I change packages names of dpkg in rawhide , because make sense and think it is
the fedora way.
libdpkg-perl -> dpkg-perl (fedora usually don't start with lib, sometime we may
use dpkg-libs or dpkg-perl.libs )
dpkg-devel -> dpkg-dev (devel is a reserved word for headers of dpkg) .
and .h .a .so -> dpkg-devel 
we always could rollback my commits .

some answers inline 


(In reply to comment #20)
> Spec URL: http://oron.fedorapeople.org/deb-package/debhelper.spec
> SRPM URL:
>   
> http://oron.fedorapeople.org/deb-package/debhelper-9.20120909-1.fc18.src.rpm
> 
> * Manual pages (In reply to comment #16):
>   - Found a far better solution: install man-pages via dh_installman
>   - Luckily, man-pages layout is FHS compliant in both Fedora/Debian
>   - The debhelper-mans.lang is generated as before (Fedora specific).
> 
> * Dependencies (In reply to comment #19 and comment 18):
>   - Build-Requires: dpkg-devel
>     # No need for specific version (both dpkg 1.15.x and 1.16.x are OK)

will be Build-Requires: dpkg-dev

>     
>   - Requires: libdpkg-perl
>     # No need to specify version, libdpkg-perl was added only at 1.16.x
>     # Not a '*-devel' package -- Good.

OK
will be Build-Requires: dpkg-perl 

>     # Minor problem: rpmlint complains about 'noarch' debhelper that
>       depends on 'lib*' package.

this took two commits dpkg-perl can't be noarch because
/usr/lib/dpkg/parsechangelog/debian 
and /usr/lib64/dpkg/parsechangelog/debian , I'm not sure what this
parsechangelog/debian do and if shouldn't be in other place than /usr/lib/dpkg/

> * So what about rpmlint?
>   - Basically, rpmlint is wrong: the libdpkg-perl contains only pure perl
>     modules (updated bug #648384 so that dpkg.spec correctly marks
>     libdpkg-perl is 'noarch')

dpkg-perl can't be noarch

> 
>   - Either we surrender to rpmlint and rename libdpkg-perl. IMO it's a bad
>     idea -- better stick to upstream names per Fedora policy.
> 
>   - Or we ignore this rpmlint error (maybe file a bug against rpmlint?)
> 
> * ... and we are still blocked by bug #648384 -- dpkg too old

we have dpkg-1.6 in rawhide , so I could review this bug properly :)  

Best regards,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vAP4ob54RY&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]