[Bug 917191] Review Request: awake - A command to 'wake on LAN' a remote host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=917191

Björn Esser <bjoern.esser@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bjoern.esser@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |bjoern.esser@xxxxxxxxx
              Flags|                            |fedora-review+

--- Comment #1 from Björn Esser <bjoern.esser@xxxxxxxxx> ---
Hi Fabian!

fedora-review and manual inspection shows me all is fine, but...

there are three rpms:

awake-1.0-1.fc20.noarch.rpm 
python-awake-1.0-1.fc20.noarch.rpm
python3-awake-1.0-1.fc20.noarch.rpm

awake-1.0-1 seems to be the main package having /usr/bin/awake executing the
main-method (located in python{,3}-awake} on system's default
python-interpreter. But there's no dependency on python{,3}-awake in the rpm...

I think you should resolve this using a virtual package (e.g. Provides: pyawake
= %{version}) in python{,3}-awake and depending on this virt-pkg in awake-1.0-1
(Requires: pyawake = %{version}). This way yum will decide itself how to
resolve this on the "cheapest" way, when a user invokes `yum install awake`.

Adding a man-page using helptoman, pod or asciidoc would be nice, too.

Since you are in packager-group since five years or so, I suppose it is ok when
you fix this on SCM.

APPROVED!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kei1ssYYUy&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]