[Bug 957465] Review Request: minised - A smaller, cheaper, faster SED implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957465

Björn Esser <bjoern.esser@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Björn Esser <bjoern.esser@xxxxxxxxx> ---
Hi Christopher!

So this was my first review for a Fedora-pkg.

On specand srpm rpmlint output was:

minised.src: W: spelling-error %description -l en_US Minix -> Mi nix, Mi-nix,
Min ix
minised.src: W: spelling-error %description -l en_US sed -> tied, ed, seed
minised.src: W: spelling-error %description -l en_US dietlibc -> dietetic
minised.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9)
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Spelling errors are false positives, but mixed-use-of-\w-and-\t was correct.

The Makefile from Sources0 provides a check-target. Why don't you use it in the
spec-file? See:
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25check_section

Please rebuild srpm with attached fixed spec-file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KBMfxxxqlc&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]