Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961168 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- = Review = Good: - rpmlint checks return: jsonp.src: W: invalid-url Source0: jsonp-1.0-src-git.tar.xz Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (manual diff okay, due to git source) - package compiles on f19 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - -javadocs ok - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EnMl9OcGg3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review