Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958865 --- Comment #3 from Paolo Bonzini <pbonzini@xxxxxxxxxx> --- > - Package contains BR: python2-devel or python3-devel > - Large documentation must go in a -doc subpackage. Will do. > [ ]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edk2-tools > > Like it says, 'Requires: edk2' needs to be fully versioned I think it's the other way round; edk2 requires edk2-tools. I'll use the fully versioned dependency. > [ ]: License field in the package spec file matches the actual license. > The bits being distributed seem to all be BSD, but there's quite a few other > hits. > > GPLv2 comes from bundled libfdt. If we eventually ship ovmf we'd need to be > able to build against system library here. We cannot, since OVMF does not run Linux executables. So, like the mingw packages, it can be packaged separately. But anyway libfdt is not used for OVMF, only for ARM. > zlib/libpng comes from bundled Python 2.7.2 . (Is that just for a devkit or > would that be included in a future ovmf?) It could be included in a future OVMF package, but isn't by default so we can just leave it out. Again, it is a version of Python that runs in the firmware so it can be packaged separately, but no problem. > [!]: Dist tag is present. > > Version: should be <date>git<commit> > Release: should be 1%{?dist} Will do. > [!]: Uses parallel make. > > Use make %{?_smp_mflags} I don't really trust this to work always... > [ ]: SourceX tarball generation or download is documented. > > Stick a comment above the Source line describing how you generated it. Will do. > [!]: Large data in /usr/share should live in a noarch subpackage if package is > arched. > Note: Arch-ed rpms have a total of 10895360 bytes in /usr/share 10895360 > edk2-tools-20130502.g732d199-1.x86_64.rpm > > Since this is all python bits I guess edk2-tools should be noarch. I will make a separate edk2-tools-python package, but note that most of the tools are written in C. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O3xrG7PHGe&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review