Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958865 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx --- Comment #1 from Cole Robinson <crobinso@xxxxxxxxxx> --- A few things flagged by fedora-review: - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires needs BuildRequires: python2-devel instead of BR: python - Large documentation must go in a -doc subpackage. Note: Documentation size is 1269760 bytes in 21 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Move pdf bits to a edk2-docs or edk2-tools-docs package [ ]: Sources contain only permissible code or content. I'll address this in a separate comment [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edk2-tools Like it says, 'Requires: edk2' needs to be fully versioned [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (4 clause) ISC", "Public domain", "Unknown or generated", "BSD (4 clause)", "MIT/X11 (BSD like)", "BSD (3 clause) ISC", "zlib/libpng", "ISC", "BSD (2 clause) GPL (v2 or later)", "BSD (3 clause)", "BSD (2 clause)", "*No copyright* Public domain". 7334 files have unknown The bits being distributed seem to all be BSD, but there's quite a few other hits. GPLv2 comes from bundled libfdt. If we eventually ship ovmf we'd need to be able to build against system library here. zlib/libpng comes from bundled Python 2.7.2 . (Is that just for a devkit or would that be included in a future ovmf?) [!]: Dist tag is present. Version: should be <date>git<commit> Release: should be 1%{?dist} [!]: Uses parallel make. Use make %{?_smp_mflags} [ ]: SourceX tarball generation or download is documented. Stick a comment above the Source line describing how you generated it. Example from virt-manager looks like: # Generate source with # git clone git://git.fedorahosted.org/git/virt-manager.git # cd virt-manager # git archive --output virt-manager-%{gitcommit}.tar.gz --prefix virt-manager-%{gitcommit}/ %{gitcommit} [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 10895360 bytes in /usr/share 10895360 edk2-tools-20130502.g732d199-1.x86_64.rpm Since this is all python bits I guess edk2-tools should be noarch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lMPDBXu4HL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review