[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915909

Gregor Tätzner <gregor@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(gregor@xxxxxxxxxx |
                   |)                           |
              Flags|                            |fedora-review+

--- Comment #7 from Gregor Tätzner <gregor@xxxxxxxxxx> ---
(In reply to comment #4)
> Some comments before posting new spec:
> 
> - I don't see anything packaged that actually uses FDL.  If you do, can you
> please clarify where it is?

Nay, we don't include any *.qdoc files. Maybe you wanna add a comment so you
won't forget.


(In reply to comment #6)
> ping, any remaining review blockers or fixes you'd like to see?

no further objections from my side...gonna approve this component.


diff -r -Nup qt5-qtdeclarative-5.0.2-1.fc18.src/qt5-qtdeclarative.spec
qt5-qtdeclarative-5.0.2-2.fc18.src/qt5-qtdeclarative.spec
--- qt5-qtdeclarative-5.0.2-1.fc18.src/qt5-qtdeclarative.spec   2013-04-11
18:28:16.000000000 +0200
+++ qt5-qtdeclarative-5.0.2-2.fc18.src/qt5-qtdeclarative.spec   2013-05-09
16:10:21.000000000 +0200
@@ -4,9 +4,9 @@
 Summary: Qt5 - QtDeclarative component
 Name:    qt5-%{qt_module}
 Version: 5.0.2
-Release: 1%{?dist}
+Release: 2%{?dist}

-# See LGPL_EXCEPTIONS.txt, LICENSE.GPL3, respectively, for exception details
+# See LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt, for details
 License: LGPLv2 with exceptions or GPLv3 with exceptions
 Url: http://qt-project.org/
 Source0:
http://releases.qt-project.org/qt5/%{version}%{?pre:-%{pre}}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz
@@ -38,7 +38,6 @@ Requires: %{name}-devel%{?_isa} = %{vers


 %build
-
 %{_qt5_qmake}

 make %{?_smp_mflags}
@@ -53,7 +52,7 @@ mkdir %{buildroot}%{_bindir}
 pushd %{buildroot}%{_qt5_bindir}
 for i in * ; do
   case "${i}" in
-    foobar)
+    qmlplugindump)
       mv $i ../../../bin/${i}-qt5
       ln -s ../../../bin/${i}-qt5 .
       ln -s ../../../bin/${i}-qt5 $i
@@ -83,17 +82,19 @@ popd
 %postun -p /sbin/ldconfig

 %files 
+%doc LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt
+%doc dist/changes*
 %{_qt5_libdir}/libQt5Qml.so.5*
 %{_qt5_libdir}/libQt5Quick.so.5*
 %{_qt5_libdir}/libQt5QuickParticles.so.5*
 %{_qt5_libdir}/libQt5QuickTest.so.5*
-%{_qt5_bindir}/qml*
-%{_bindir}/qml*
 %{_qt5_plugindir}/accessible/libqtaccessiblequick.so
 %{_qt5_plugindir}/qmltooling/
 %{_qt5_archdatadir}/qml/

 %files devel
+%{_bindir}/qml*
+%{_qt5_bindir}/qml*
 %{_qt5_headerdir}/Qt*/
 %{_qt5_libdir}/libQt5Qml.so
 %{_qt5_libdir}/libQt5Qml.prl
@@ -109,6 +110,10 @@ popd


 %changelog
+* Fri Apr 12 2013 Rex Dieter <rdieter@xxxxxxxxxxxxxxxxx> 5.0.2-2
+- fix conflicts with qt4-devel
+- include license files, dist/changes*
+
 * Thu Apr 11 2013 Rex Dieter <rdieter@xxxxxxxxxxxxxxxxx> 5.0.2-1
 - 5.0.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aVLskFkR0g&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]