Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921797 --- Comment #12 from Bojan Smojver <bojan@xxxxxxxxxxxxx> --- (In reply to comment #7) > I've done a quick review: > > Look into your special and found some problem: > > 1. Your Source0 use %{version} already so why not replace the %{name} like > this: > > https://launchpad.net/%{name}/1.1/%{version}/+download/%{name}-%{version}. > tar.gz Done in: ftp://ftp.rexursive.com/pub/pypolicyd-spf/pypolicyd-spf-1.1.2-2.fc18.src.rpm ftp://ftp.rexursive.com/pub/pypolicyd-spf/pypolicyd-spf.spec > 2. No need this in %install section: > > rm -rf $RPM_BUILD_ROOT This is the result of rpmdev-newspec --type python. Also, it is mentioned here: https://fedoraproject.org/wiki/Packaging:Python I don't know whether it's truly required, but it does not hurt, so I'll leave it in. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=piiEr469fJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review