[Bug 924310] Review Request: mate-document-viewer - Document viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924310

Alex G. <mr.nuke.me@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #18 from Alex G. <mr.nuke.me@xxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- update-desktop-database is invoked when required
  Note: desktop file(s) in mate-document-viewer
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

False positive.

================================================================================
[x]: Package requires other packages for directories it uses.

Nothing we can do about these two. We need the other packages to own their own
dirs.

================================================================================
[x]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate-
     document-viewer-libs , mate-document-viewer-devel , mate-document-viewer-
     caja

Really false positive.

================================================================================
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).

You forgot to update
http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec
srpm has new spec. using that one for the review.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate-
     document-viewer-libs , mate-document-viewer-devel , mate-document-viewer-
     caja
[x]: glib-compile-schemas is run if required
     Note: gschema file(s) in mate-document-viewer
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "GPL
     (v2 or later)", "Unknown or generated". 34 files have unknown license.
     Detailed output of licensecheck in /home/mrnuke/924310-mate-document-
     viewer/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked when required
     Note: icons in mate-document-viewer
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 153600 bytes in 6 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
     such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: mate-document-viewer-1.6.0-4.fc20.x86_64.rpm
          mate-document-viewer-libs-1.6.0-4.fc20.x86_64.rpm
          mate-document-viewer-devel-1.6.0-4.fc20.x86_64.rpm
          mate-document-viewer-caja-1.6.0-4.fc20.x86_64.rpm
mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer
mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer
mate-document-viewer-libs.x86_64: W: no-documentation
mate-document-viewer-devel.x86_64: W: no-documentation
mate-document-viewer-caja.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint mate-document-viewer-devel mate-document-viewer-libs
mate-document-viewer-caja mate-docu 
ment-viewer
mate-document-viewer-devel.x86_64: W: no-documentation
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6
mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatrilview.so.3.0.0 /lib64/libfontconfig.so.1
mate-document-viewer-libs.x86_64: W: no-documentation
mate-document-viewer-caja.x86_64: W: no-documentation
mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer
mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer
4 packages and 0 specfiles checked; 0 errors, 18 warnings.
# echo 'rpmlint-done:'



Diff spec file in url and in SRPM
---------------------------------
--- /home/mrnuke/924310-mate-document-viewer/srpm/mate-document-viewer.spec   
2013-05-13 08:58:21.262466827 -0500
+++
/home/mrnuke/924310-mate-document-viewer/srpm-unpacked/mate-document-viewer.spec
   2013-05-13 08:58:21.727466853 -0500
@@ -5,5 +5,5 @@
 Name:           mate-document-viewer
 Version:        1.6.0
-Release:        3%{?dist}
+Release:        4%{?dist}
 Summary:        Document viewer
 License:        GPLv2+ and LGPLv2+ and MIT
@@ -37,5 +37,6 @@
 BuildRequires:  djvulibre-devel

-Requires: %{name}-libs%{?_isa} = %{version}-%{release}
+Requires:       %{name}-libs%{?_isa} = %{version}-%{release}
+Requires:       %{name}-data = %{version}-%{release}
 Requires:       hicolor-icon-theme

@@ -55,5 +56,15 @@

 %description libs
-This package contains shared libraries needed for mate-document-viewer
+This package contains shared libraries needed for mate-document-viewer.
+
+
+%package data
+Summary: Data files for the mate-document-viewer
+Group: Applications/Publishing
+BuildArch: noarch
+Requires: %{name}%{?_isa} = %{version}-%{release}
+
+%description data
+This package contains shared data needed for mate-document-viewer.


@@ -116,4 +127,8 @@
 rm -f $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/icon-theme.cache

+# remove of gsetting,convert file, no need for this in fedora
+# because MATE starts with gsetting in fedora.
+rm -f $RPM_BUILD_ROOT%{_datadir}/MateConf/gsettings/atril.convert
+
 %find_lang atril

@@ -144,5 +159,5 @@


-%files -f atril.lang
+%files
 %doc README COPYING NEWS AUTHORS
 %{_bindir}/*
@@ -155,10 +170,7 @@
 %{_datadir}/dbus-1/services/org.mate.atril.Daemon.service
 %{_datadir}/glib-2.0/schemas/org.mate.Atril.gschema.xml
-%{_datadir}/MateConf/gsettings/atril.convert
-%{_datadir}/mate/help/atril/
 %{_datadir}/omf/atril/
-%doc %{_docdir}/%{name}-%{version}/atril/atril.html
-%doc %{_docdir}/%{name}-%{version}/atril/atril_start_window.png
 %{_datadir}/thumbnailers/atril.thumbnailer
+%exclude %{_docdir}/%{name}-%{version}/atril

 %files libs
@@ -173,4 +185,9 @@
 %{_libdir}/girepository-1.0/AtrilView-1.5.0.typelib

+%files data -f atril.lang
+%doc %{_docdir}/%{name}-%{version}/atril/atril.html
+%doc %{_docdir}/%{name}-%{version}/atril/atril_start_window.png
+%{_datadir}/mate/help/atril/
+
 %files devel
 %dir %{_includedir}/atril/
@@ -188,4 +205,11 @@

 %changelog
+* Sat May 11 2013 Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> - 1.6.0-4
+- remove gsettings convert file
+- create -data noarch subpackage
+- move docs in -data subpackage
+- move help dir in -data subpackage
+- move locale in -data subpackage
+
 * Fri May 10 2013 Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> - 1.6.0-3
 - remove -dvi, -djvu, -xps subpackages and move the libs to -libs subpackage


Requires
--------
mate-document-viewer-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libatrildocument.so.3()(64bit)
    libatrilview.so.3()(64bit)
    mate-document-viewer(x86-64)
    pkgconfig(atril-document-1.5.0)
    pkgconfig(gio-2.0)
    pkgconfig(gthread-2.0)
    pkgconfig(gtk+-2.0)

mate-document-viewer-libs (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libarchive.so.13()(64bit)
    libatk-1.0.so.0()(64bit)
    libatrildocument.so.3()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libdjvulibre.so.21()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgailutil.so.18()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libgxps.so.2()(64bit)
    libkpathsea.so.6()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpoppler-glib.so.8()(64bit)
    libpthread.so.0()(64bit)
    libspectre.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libt1.so.5()(64bit)
    libtiff.so.5()(64bit)
    libtiff.so.5(LIBTIFF_4.0)(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libz.so.1()(64bit)
    mate-document-viewer(x86-64)
    rtld(GNU_HASH)

mate-document-viewer-caja (rpmlib, GLIBC filtered):
    libatk-1.0.so.0()(64bit)
    libatrildocument.so.3()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libz.so.1()(64bit)
    mate-document-viewer(x86-64)
    mate-file-manager
    rtld(GNU_HASH)

mate-document-viewer (rpmlib, GLIBC filtered):
    /bin/sh
    hicolor-icon-theme
    libICE.so.6()(64bit)
    libSM.so.6()(64bit)
    libX11.so.6()(64bit)
    libatk-1.0.so.0()(64bit)
    libatrildocument.so.3()(64bit)
    libatrilview.so.3()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgailutil.so.18()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libm.so.6()(64bit)
    libmate-keyring.so.1()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libz.so.1()(64bit)
    mate-document-viewer-data
    mate-document-viewer-libs(x86-64)
    rtld(GNU_HASH)



Provides
--------
mate-document-viewer-devel:
    mate-document-viewer-devel
    mate-document-viewer-devel(x86-64)
    pkgconfig(atril-document-1.5.0)
    pkgconfig(atril-view-1.5.0)

mate-document-viewer-libs:
    libatrildocument.so.3()(64bit)
    libatrilview.so.3()(64bit)
    libcomicsdocument.so()(64bit)
    libdjvudocument.so()(64bit)
    libdvidocument.so()(64bit)
    libpdfdocument.so()(64bit)
    libpsdocument.so()(64bit)
    libtiffdocument.so()(64bit)
    libxpsdocument.so()(64bit)
    mate-document-viewer-libs
    mate-document-viewer-libs(x86-64)

mate-document-viewer-caja:
    libatril-properties-page.so()(64bit)
    mate-document-viewer-caja
    mate-document-viewer-caja(x86-64)

mate-document-viewer:
    mate-document-viewer
    mate-document-viewer(x86-64)
    mimehandler(application/oxps)
    mimehandler(application/pdf)
    mimehandler(application/postscript)
    mimehandler(application/vnd.ms-xpsdocument)
    mimehandler(application/x-bzdvi)
    mimehandler(application/x-bzpdf)
    mimehandler(application/x-bzpostscript)
    mimehandler(application/x-cb7)
    mimehandler(application/x-cbr)
    mimehandler(application/x-cbt)
    mimehandler(application/x-cbz)
    mimehandler(application/x-dvi)
    mimehandler(application/x-gzdvi)
    mimehandler(application/x-gzpdf)
    mimehandler(application/x-gzpostscript)
    mimehandler(image/tiff)
    mimehandler(image/vnd.djvu)
    mimehandler(image/x-bzeps)
    mimehandler(image/x-eps)
    mimehandler(image/x-gzeps)



Unversioned so-files
--------------------
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libcomicsdocument.so
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libdjvudocument.so
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libdvidocument.so
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpdfdocument.so
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpsdocument.so
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libtiffdocument.so
mate-document-viewer-libs: /usr/lib64/atril/3/backends/libxpsdocument.so
mate-document-viewer-caja:
/usr/lib64/caja/extensions-2.0/libatril-properties-page.so

Source checksums
----------------
http://pub.mate-desktop.org/releases/1.6/mate-document-viewer-1.6.0.tar.xz :
  CHECKSUM(SHA256) this package     :
40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf
  CHECKSUM(SHA256) upstream package :
40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/bin/fedora-review -b 924310

This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o4MZlIOxpj&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]