[Bug 921797] Review Request: pypolicyd-spf - SPF Policy Server for Postfix (Python implementation)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=921797

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cickumqt@xxxxxxxxx

--- Comment #7 from Christopher Meng <cickumqt@xxxxxxxxx> ---
I've done a quick review:

Look into your special and found some problem:

1. Your Source0 use %{version} already so why not replace the %{name} like
this:

https://launchpad.net/%{name}/1.1/%{version}/+download/%{name}-%{version}.tar.gz

2. No need this in %install section:

rm -rf $RPM_BUILD_ROOT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uNY2qkPKpB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]