Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959926 --- Comment #4 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Almost. ;) * You've missed using %cmake instead of defining all the *FLAGS environment variables yourself. * Some reviewers demand that package submitters increase the "Release" value for every update and add a %changelog entry, also during review: https://fedoraproject.org/wiki/Packaging:FrequentlyMadeMistakes It's good practice and makes running rpmdev-diff and rpmdiff more convenient. * As why you've requested a "hardened build", not sure: https://fedoraproject.org/wiki/Packaging:Guidelines#PIE * Unowned directories fun: libyui has been changed to not include /usr/share/doc/libyui-3.0.3/ -- that directory is "unowned" now: $ rpmls -p libyui-3.0.3-1.fc19.x86_64.rpm|grep ^d drwxr-xr-x /usr/lib64/yui drwxr-xr-x /usr/share/libyui drwxr-xr-x /usr/share/libyui/theme libyui-devel either needs to "Requires: cmake" (only for directory ownership) OR include a %dir entry for /usr/lib64/cmake/ (the latter is permitted): https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership If you choose to include the cmake directory in your package, be especially careful that the file permissions are exactly the same as in the cmake package. libyui-doc has been changed to not include the "html" directory: $ rpmls -p libyui-doc-3.0.3-1.fc19.noarch.rpm|grep ^d drwxr-xr-x /usr/share/doc/libyui-3.0.3/html/search The following patch shall fix the directory issues. Btw, it's okay to include full directory trees as you had done before. Example: 1) %{_includedir}/yui/ 2) %{_includedir}/yui 3) %dir %{_includedir}/yui %{_includedir}/yui/* Those three are equivalent. The Wiki _tries_ to explain it. --- libyui.spec.orig 2013-05-12 22:24:36.700740024 +0200 +++ libyui.spec 2013-05-12 22:26:51.794385741 +0200 @@ -118,6 +118,7 @@ %dir %{_libdir}/yui %dir %{_datadir}/%{name} %dir %{_datadir}/%{name}/theme +%dir %{_defaultdocdir}/%{name}-%{version} %doc %{_defaultdocdir}/%{name}-%{version}/C* @@ -126,6 +127,7 @@ %dir %{_includedir}/yui %{_includedir}/yui/* %{_libdir}/pkgconfig/%{name}.pc +%dir %{_libdir}/cmake %dir %{_libdir}/cmake/%{name} %{_libdir}/cmake/%{name}/* %dir %{_datadir}/%{name}/buildtools @@ -133,7 +135,9 @@ %files doc -%doc %{_defaultdocdir}/%{name}-%{version}/*/* +%dir %{_defaultdocdir}/%{name}-%{version} +%doc %{_defaultdocdir}/%{name}-%{version}/examples/ +%doc %{_defaultdocdir}/%{name}-%{version}/html/ %changelog -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sLh9hZ1OjU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review