[Bug 955913] Review Request: nsnake - Classic snake game on console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=955913

--- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to comment #3)
> Initial rpmlint stuff:
> 
> nsnake.x86_64: E: setuid-binary /usr/bin/nsnake root 04755L
> The file is setuid; this may be dangerous, especially if this file is setuid
> root. Sometimes file capabilities can be used instead of setuid bits.

Fixed.

> nsnake.x86_64: E: non-standard-executable-perm /usr/bin/nsnake 04755L
> A standard executable should have permission set to 0755. If you get this
> message, it means that you have a wrong executable permissions in some files
> included in your package.

Fixed.

> nsnake.x86_64: W: spurious-executable-perm /usr/share/man/man6/nsnake.6.gz
> The file is installed with executable permissions, but was identified as one
> that probably should not be executable.  Verify if the executable bits are
> desired, and remove if not.

Fixed.

> nsnake.x86_64: W: manual-page-warning /usr/share/man/man6/nsnake.6.gz 1:
> warning: macro `"' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> nsnake.x86_64: W: manual-page-warning /usr/share/man/man6/nsnake.6.gz 5:
> warning: macro `"----------------------------------' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> nsnake.x86_64: W: manual-page-warning /usr/share/man/man6/nsnake.6.gz 9:
> warning: macro `"--------------------------------' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> nsnake.x86_64: W: manual-page-warning /usr/share/man/man6/nsnake.6.gz 17:
> warning: macro `"-------------------------------' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> nsnake.x86_64: W: manual-page-warning /usr/share/man/man6/nsnake.6.gz 44:
> warning: macro `"---------------------------------' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> nsnake.x86_64: W: manual-page-warning /usr/share/man/man6/nsnake.6.gz 63:
> warning: macro `"-----------------------------------' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.

Ignored.

> nsnake-debuginfo.x86_64: E: debuginfo-without-sources
> This debuginfo package appears to contain debug symbols but no source files.
> This is often a sign of binaries being unexpectedly stripped too early during
> the build, or being compiled without compiler debug flags (which again often
> is a sign of distro's default compiler flags ignored which might have
> security
> consequences), or other compiler flags which result in rpmbuild's debuginfo
> extraction not working as expected.  Verify that the binaries are not
> unexpectedly stripped and that the intended compiler flags are used.

Fixed.

> These should all be fixed. You should be able to patch out the strip during
> build,

Fixed.

> Also, you might
> consider running make dox and including the output in %doc.

Sounds good but I don't know if it's really necessary.

Please check if the docs directory structure is good or bad, thanks!

Spec URL: http://cicku.me/nsnake.spec
SRPM URL: http://cicku.me/nsnake-1.5-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4w0pfYKS2r&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]