Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894604 --- Comment #10 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #9) > Hi Paulo. Hi Antonio, > [x]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in coin-or- > Ipopt-doc > > This subpackage provides just .html documentation files, so it doesn't need > any fully versioned dependency. Added missing "Requires: %{name} = %{version}-%{release}" > [x]: Package complies to the Packaging Guidelines > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Unknown or generated". 1 files have unknown license. Detailed output of > licensecheck in /home/sagitter/894604-coin-or-Ipopt/licensecheck.txt > > ltmain.sh file is shipped with a GPLv2+ license. > License field should be "EPL and GPLv2+" . > (http://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Mixed_Source_Licensing_Scenario) Unsure about this, but for the sake of following guidelines changed to "License: EPL and GPLv2+" > Generic: > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0 > > A new release is already online. :) That was fast :-) Just updated. > [x]: Uses parallel make. > [-]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > [x]: Final provides and requires are sane (see attachments). > [x]: Package functions as described. > [!]: Latest version is packaged. > > http://www.coin-or.org/download/source/Ipopt/Ipopt-3.11.0.zip Fixed as commented above. I think part of this was my request to upstream to correct several underlink issues in different coin-or packages. > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > Note: Arch-ed rpms have a total of 37089280 bytes in /usr/share 37089280 > coin-or-Ipopt-3.10.4-1.fc20.x86_64.rpm Already done, bogus warning I think, -doc package is noarch. > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Spec file according to URL is the same as in SRPM. > > > Rpmlint > ------- > Checking: coin-or-Ipopt-3.10.4-1.fc20.x86_64.rpm > coin-or-Ipopt-devel-3.10.4-1.fc20.x86_64.rpm > coin-or-Ipopt-doc-3.10.4-1.fc20.noarch.rpm > coin-or-Ipopt.x86_64: W: spelling-error %description -l en_US nonconvex -> > non convex, non-convex, convex > coin-or-Ipopt.x86_64: W: spelling-error %description -l en_US differentiable > -> differential, differentiated, differentiate > coin-or-Ipopt.x86_64: W: shared-lib-calls-exit /usr/lib64/libipopt.so.1.8.4 > exit@GLIBC_2.2.5 > coin-or-Ipopt-devel.x86_64: W: no-documentation > 3 packages and 0 specfiles checked; 0 errors, 4 warnings. > > > > > Rpmlint (installed packages) > ---------------------------- > # rpmlint coin-or-Ipopt-devel coin-or-Ipopt-doc coin-or-Ipopt > coin-or-Ipopt-devel.x86_64: W: no-documentation > coin-or-Ipopt.x86_64: W: spelling-error %description -l en_US nonconvex -> > non convex, non-convex, convex > coin-or-Ipopt.x86_64: W: spelling-error %description -l en_US differentiable > -> differential, differentiated, differentiate > coin-or-Ipopt.x86_64: W: undefined-non-weak-symbol > /usr/lib64/libipopt.so.1.8.4 MPI::Datatype::Free() > coin-or-Ipopt.x86_64: W: undefined-non-weak-symbol I think the mpi undefined are expected. > /usr/lib64/libipopt.so.1.8.4 dsymv_ > coin-or-Ipopt.x86_64: W: undefined-non-weak-symbol > /usr/lib64/libipopt.so.1.8.4 dgetrs_ Add -llapack to --with-mumps-lib > coin-or-Ipopt.x86_64: W: undefined-non-weak-symbol > /usr/lib64/libipopt.so.1.8.4 dlclose Added a new underlink patch to explicitly link with -ldl. Update: - Update to latest upstream release. - Adjust patches and build for sources now in toplevel directory. Spec URL: http://pcpa.fedorapeople.org/coin-or/coin-or-Ipopt.spec SRPM URL: http://pcpa.fedorapeople.org/coin-or/coin-or-Ipopt-3.11.0-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5eHlOOJRFS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review