Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: kdewebdev https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225968 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-03-08 10:47 EST ------- 3. MUST -Requires: kdelibs-devel >= 1:%{qt_version} +Requires: kdelibs-devel 4. MUST: add to %files %doc COPYING COPYING-DOCS 5. SHOULD consider dropping ancient/deprecated (and unversioned, btw): Obsoletes: WebMaker Obsoletes: quanta ... Obsoletes: quanta-devel If you still want to keep any of these, they ought to be versioned (and appropriate Provides: considered as well) 6. SHOULD drop configure option: --with-qt-libraries=$QTDIR/lib shouldn't be needed. 7. SHOULD consider adding runtime dep (for quanta): Requires: tidy Address MUST items, and I'll APPROVE this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review