[Bug 924310] Review Request: mate-document-viewer - Document viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924310

--- Comment #16 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> ---
(In reply to comment #15)
> OK, the big issues have gone away.
> 
> =============================================================================
> ===
> [?]: Package requires other packages for directories it uses.
> 
> Currently, the folloing lack proper Requires:
> %{_datadir}/MateConf/
> If mate-conf is obsoleted, what do we do with this?
> 
> %{_datadir}/mate/ (bug 961950)
> %{_libdir}/caja/ (bug 961992)
> 
> =============================================================================
> ===
> [?]: Requires correct, justified where necessary.
> 
> Not evaluating until we figure out what to do with:
> %{_datadir}/MateConf/gsettings/atril.convert
> 
I will simply remove this file from the package, because MATE started with
gsettings in f17/f18. So we can expect that there is no user wo have to convert
his mateconf user settings in fedora.
Agree?
But i think this is a general issue with 60 % of MATE packages in fedora,
because non of them has a require mate-conf anymore.
I'm curious if Dan will own this directory with mate-desktop when he obsolete
mate-conf in near future.
> =============================================================================
> ===
> [?]: Large data in /usr/share should live in a noarch subpackage if package
> is
>      arched.
>      Note: Arch-ed rpms have a total of 4454400 bytes in /usr/share 378880
>      mate-document-viewer-devel-1.6.0-3.fc20.x86_64.rpm 4075520
> mate-document-
>      viewer-1.6.0-3.fc20.x86_64.rpm
> 
> Have a look at what data can safely be moved to a noarch package,
> %{name}-data.
> Possible candidates:
> locale				(2.4MB)
> %{_datadir}/mate/help/atril/	(1.1MB)
> maybe others
> 
I will create this subpackage.

> Rpmlint (installed packages)
> ----------------------------
> # rpmlint mate-document-viewer-devel mate-document-viewer-libs
> mate-document-viewer-caja mate-docu 
> ment-viewer
> mate-document-viewer-devel.x86_64: W: no-documentation
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6
> mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libatrilview.so.3.0.0 /lib64/libfontconfig.so.1
> 
> A bunch of false positives that I bet will go away if I clear the mock cahe.

I know this rpmlint warning from other packages too.
There are always the same libs which can't be fixed with the sed command.
libgthread, libpango ........

Ok, updated Spec and SRPM comming soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DrvWFBj32m&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]