Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920879 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalevlember@xxxxxxxxx --- Comment #8 from Kalev Lember <kalevlember@xxxxxxxxx> --- (In reply to comment #4) > (In reply to comment #2) > > 1.I think you should use %{name} to replace "tali" as many as possible. > > A package's name isn't subject to change. I suppose %{name} helps the file > be a better template for common stuff, but for specifically installed files > (especially for the few in this game), explicitly stating the name seems > reasonable to me. I agree with Tanner. Changing something like: desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/gtali.desktop to: desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/g%{name}.desktop ... would be just silly. The %{name} macro is for the _rpm package's_ name and even if a file name happens to coincide with the name of the rpm, it doesn't automatically mean we should use the macro there. There are semantic differences. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Itf2SKZUBk&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review