Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877779 Tomas Radej <tradej@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #7 from Tomas Radej <tradej@xxxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Package requires other packages for directories it uses. [!]: Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java [!]: Javadoc subpackages have Requires: jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java >>>> Requires on jpackage-utils is necessary [!]: Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in openwebbeans- arquillian, openwebbeans-ee, openwebbeans-ee-common, openwebbeans-ejb, openwebbeans-impl, openwebbeans-jee5-ejb-resource, openwebbeans-jms, openwebbeans-jsf, openwebbeans-osgi, openwebbeans-resource, openwebbeans- spi, openwebbeans-test, openwebbeans-tomcat7, openwebbeans-web See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage >>>> The dependency on main package must be in form of: >>>> Requires: %{name}%{?_isa} = %{version}-%{release} ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [!]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openwebbeans-arquillian , openwebbeans-ee , openwebbeans-ee-common , openwebbeans-ejb , openwebbeans-impl , openwebbeans-jee5-ejb-resource , openwebbeans-jms , openwebbeans-jsf , openwebbeans-osgi , openwebbeans- resource , openwebbeans-spi , openwebbeans-test , openwebbeans-tomcat7 , openwebbeans-web , openwebbeans-javadoc [ ]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". 1 files have unknown license. Detailed output of licensecheck in /home/tradej/reviews/877779-openwebbeans/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 307200 bytes in 30 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [-]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openwebbeans-1.1.8-1.fc20.noarch.rpm openwebbeans-arquillian-1.1.8-1.fc20.noarch.rpm openwebbeans-ee-1.1.8-1.fc20.noarch.rpm openwebbeans-ee-common-1.1.8-1.fc20.noarch.rpm openwebbeans-ejb-1.1.8-1.fc20.noarch.rpm openwebbeans-impl-1.1.8-1.fc20.noarch.rpm openwebbeans-jee5-ejb-resource-1.1.8-1.fc20.noarch.rpm openwebbeans-jms-1.1.8-1.fc20.noarch.rpm openwebbeans-jsf-1.1.8-1.fc20.noarch.rpm openwebbeans-osgi-1.1.8-1.fc20.noarch.rpm openwebbeans-resource-1.1.8-1.fc20.noarch.rpm openwebbeans-spi-1.1.8-1.fc20.noarch.rpm openwebbeans-test-1.1.8-1.fc20.noarch.rpm openwebbeans-tomcat7-1.1.8-1.fc20.noarch.rpm openwebbeans-web-1.1.8-1.fc20.noarch.rpm openwebbeans-javadoc-1.1.8-1.fc20.noarch.rpm openwebbeans-tomcat7.noarch: E: explicit-lib-dependency tomcat-lib 16 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint openwebbeans-javadoc openwebbeans-arquillian openwebbeans-web openwebbeans-jms openwebbeans-impl openwebbeans openwebbeans-tomcat7 openwebbeans-jsf openwebbeans-test openwebbeans-ee-common openwebbeans-spi op enwebbeans-ejb openwebbeans-ee openwebbeans-osgi openwebbeans-resource openwebbeans-jee5-ejb-resource openwebbeans-tomcat7.noarch: E: explicit-lib-dependency tomcat-lib 16 packages and 0 specfiles checked; 1 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- openwebbeans-javadoc (rpmlib, GLIBC filtered): jpackage-utils openwebbeans-arquillian (rpmlib, GLIBC filtered): arquillian-core jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi shrinkwrap openwebbeans-web (rpmlib, GLIBC filtered): atinject cdi-api jboss-el-2.2-api jboss-interceptors-1.1-api jboss-jsf-2.1-api jboss-jsp-2.2-api jboss-servlet-3.0-api jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-jms (rpmlib, GLIBC filtered): atinject cdi-api jboss-jms-1.1-api jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-impl (rpmlib, GLIBC filtered): atinject cdi-api javassist jboss-el-2.2-api jboss-interceptors-1.1-api jpackage-utils objectweb-asm openwebbeans openwebbeans-spi scannotation openwebbeans (rpmlib, GLIBC filtered): java jpackage-utils openwebbeans-tomcat7 (rpmlib, GLIBC filtered): atinject cdi-api jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-web tomcat-lib openwebbeans-jsf (rpmlib, GLIBC filtered): atinject cdi-api jboss-el-2.2-api jboss-jsf-2.1-api jboss-servlet-3.0-api jpackage-utils junit openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-test (rpmlib, GLIBC filtered): atinject cdi-api jboss-el-2.2-api jboss-interceptors-1.1-api jboss-servlet-3.0-api jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-web openwebbeans-ee-common (rpmlib, GLIBC filtered): atinject cdi-api jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-spi (rpmlib, GLIBC filtered): atinject cdi-api geronimo-annotation geronimo-jta geronimo-validation hamcrest12 jboss-el-2.2-api jboss-jsf-2.1-api jboss-servlet-3.0-api jpackage-utils junit openwebbeans openwebbeans-ejb (rpmlib, GLIBC filtered): atinject cdi-api jboss-ejb-3.1-api jboss-interceptors-1.1-api jpackage-utils junit openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-ee (rpmlib, GLIBC filtered): atinject cdi-api geronimo-jta geronimo-validation jboss-el-2.2-api jboss-jsf-2.1-api jboss-servlet-3.0-api jpackage-utils junit openwebbeans openwebbeans-ee-common openwebbeans-impl openwebbeans-spi openwebbeans-osgi (rpmlib, GLIBC filtered): atinject cdi-api eclipse-equinox-osgi jboss-servlet-3.0-api jpackage-utils openwebbeans openwebbeans-impl openwebbeans-spi xbean openwebbeans-resource (rpmlib, GLIBC filtered): atinject cdi-api hibernate-jpa-2.0-api jpackage-utils junit openwebbeans openwebbeans-impl openwebbeans-spi openwebbeans-jee5-ejb-resource (rpmlib, GLIBC filtered): atinject cdi-api jboss-ejb-3.1-api jpackage-utils junit openwebbeans openwebbeans-impl openwebbeans-resource openwebbeans-spi Provides -------- openwebbeans-javadoc: openwebbeans-javadoc openwebbeans-arquillian: mvn(org.apache.openwebbeans.arquillian:owb-arquillian-parent) mvn(org.apache.openwebbeans.arquillian:owb-arquillian-standalone) openwebbeans-arquillian osgi(owb-arquillian-standalone) openwebbeans-web: mvn(org.apache.openwebbeans:openwebbeans-web) openwebbeans-web osgi(openwebbeans-web) openwebbeans-jms: mvn(org.apache.openwebbeans:openwebbeans-jms) openwebbeans-jms osgi(openwebbeans-jms) openwebbeans-impl: mvn(org.apache.openwebbeans:openwebbeans-impl) openwebbeans-impl osgi(openwebbeans-impl) openwebbeans: mvn(org.apache.openwebbeans:openwebbeans) openwebbeans openwebbeans-tomcat7: mvn(org.apache.openwebbeans:openwebbeans-tomcat7) openwebbeans-tomcat7 osgi(openwebbeans-tomcat7) openwebbeans-jsf: mvn(org.apache.openwebbeans:openwebbeans-jsf) openwebbeans-jsf osgi(openwebbeans-jsf) openwebbeans-test: mvn(org.apache.openwebbeans.test:cditest) mvn(org.apache.openwebbeans.test:cditest-owb) mvn(org.apache.openwebbeans.test:parent) openwebbeans-test osgi(cditest) osgi(cditest-owb) osgi(openwebbeans-impl) openwebbeans-ee-common: mvn(org.apache.openwebbeans:openwebbeans-ee-common) openwebbeans-ee-common osgi(openwebbeans-ee-common) openwebbeans-spi: mvn(org.apache.openwebbeans:openwebbeans-spi) openwebbeans-spi osgi(openwebbeans-spi) openwebbeans-ejb: mvn(org.apache.openwebbeans:openwebbeans-ejb) openwebbeans-ejb osgi(openwebbeans-ejb) openwebbeans-ee: mvn(org.apache.openwebbeans:openwebbeans-ee) openwebbeans-ee osgi(openwebbeans-ee) openwebbeans-osgi: mvn(org.apache.openwebbeans:openwebbeans-osgi) openwebbeans-osgi osgi(openwebbeans-osgi) openwebbeans-resource: mvn(org.apache.openwebbeans:openwebbeans-resource) openwebbeans-resource osgi(openwebbeans-resource) openwebbeans-jee5-ejb-resource: mvn(org.apache.openwebbeans:openwebbeans-jee5-ejb-resource) openwebbeans-jee5-ejb-resource osgi(openwebbeans-jee5-ejb-resource) MD5-sum check ------------- http://www.apache.org/dist/openwebbeans/1.1.8/openwebbeans-1.1.8-source-release.zip : CHECKSUM(SHA256) this package : 512623e56f197e27a658903ad078358a171a4d0ddae5f6b23e648a6eee36e75b CHECKSUM(SHA256) upstream package : 512623e56f197e27a658903ad078358a171a4d0ddae5f6b23e648a6eee36e75b Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 877779 -m fedora-rawhide-x86_64 *** NOT APPROVED *** Issues described at the top of this post. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HWBxD6EJT7&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review