Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: kdbg https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225960 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-03-08 09:38 EST ------- 2. MUST: add missing icon scriptlets %post touch --no-create %{_datadir}/icons/hicolor ||: gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2> /dev/null ||: %postun touch --no-create %{_datadir}/icons/hicolor ||: gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2> /dev/null ||: 3. MUST: change in %files %{_datadir}/applications/* to %{_datadir}/applications/kde/* (ie, this package shouldn't own %_datadir/applications/kde dir) 4. (corrolary to 3) SHOULD fix desktop-file-install invocation (it currently does nothing) 5. MUST add to %files %doc BUGS ChangeLog COPYING README TODO (ok, only COPYING is MUST, the others are SHOULD) 6. misc SHOULDs: -BuildRequires: kdelibs-devel >= 6:3.5.6 +BuildRequires: kdelibs-devel drop --with-qt-dir=$QTDIR from configure flags (it shouldn't be needed) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review