Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 --- Comment #2 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- (In reply to comment #1) > So, some general comments. ;) Thank you for your answer, I'll provide new spec and source rpm asap. But first I can answer your questions. > - Usually when we package extensions or plugins for a package they have the > base package name in the name of the extension or plugin. So, you might > consider renaming this: > varnish-extension-querystring or varnish-vmod-querystring? I see the point, and varnish-vmod-querystring sounds better (and more community-ish) to me, I'll use that. > - You cannot do conditional builds like that in the Fedora buildsystem. I'd > suggest doing a 'BuildRequires: varnish-exact-version' and set it to that > version. Then, when varnish is updated, you update that to the new version > and rebuild. Ok then it would be my responsibility to follow varnish's releases and make the vmod stay in sync ? Also, the varnish package is not useful at build time, unless there's a devel package I've missed with all the bits needed by vmods. This is the reason why I also build varnish from the source. > - This needs patches to varnish? Have you opened a bug to get the Fedora > varnish maintainer(s) feedback on applying those? No I have not, I've discovered a segfault issue when I started building the vmod against different versions of varnish on different archs. Since at the time I opened this issue only varnish 3.0.3 was available in the repo, I took the patches from the source RPM for Fedora 18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UzCR6wdck3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review