Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960771 --- Comment #6 from Miloslav Trmač <mitr@xxxxxxxxxx> --- Thanks for the review. (In reply to comment #5) > Status: NEEDSWORK > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "GPL (v2 or later)", "LGPL (v2 or later) (with > incorrect > FSF address)". 3 files have unknown license. Detailed output of > licensecheck in /home/mrnuke/960771-polkit-pkla-compat/licensecheck.txt > > > License: LGPLv2+ > > The file identified as GPLv2 is ltmain.sh. That's part of the autotools build > system, so it's not a distributed with the binary rpm. The Apache licensed files > are also just part of the testsuite, and not included in the binary rpm. Please > consider putting a comment above the License tag explaining this. Added. > > polkit-pkla-compat.x86_64: W: summary-not-capitalized C polkit rules for compatibility with pklocalauthority > "Rules for polkit compatibility with pklocalauthority" > "Legacy polkit rules for compatibility with pklocalauthority" > would silence this one. Fair enough, modified to > Rules for polkit to add compatibility with pklocalauthority > > polkit-pkla-compat.x86_64: W: non-standard-gid /var/lib/polkit-1 polkitd > > polkit-pkla-compat.x86_64: W: non-standard-gid /etc/polkit-1/localauthority polkitd > > %dir %attr(0750,root,polkitd) %dir %{_sysconfdir}/polkit-1/localauthority > > %dir %attr(0750,root,polkitd) %{_localstatedir}/lib/polkit-1 > Did you mean polkituser? No, the group name is literally "polkitd". > > polkit-pkla-compat.x86_64: E: non-standard-dir-perm /var/lib/polkit-1 0750L > > polkit-pkla-compat.x86_64: E: non-standard-dir-perm /etc/polkit-1/localauthority 0750L > As rpmlint explains, "A standard directory should have permission set to > 0755." These permissions are intentional; the authorization policy is intended to not be accessible to any user but root, and only readable by the polkitd daemon. Upstream README and notes at bottom of configure.ac recommend the same thing. > > polkit-pkla-compat.x86_64: E: incorrect-fsf-address /usr/share/doc/polkit-pkla-compat-0.1/COPYING > This file contains an older address for FSF. Please contact upstream to fix > this, but do NOT patch the license file yourself. Updated upstream. Updated package: http://people.redhat.com/mitr/packaging/polkit-pkla-compat-0.1-2.fc18.src.rpm http://people.redhat.com/mitr/packaging/polkit-pkla-compat.spec (overwritten) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mFONTm5EEc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review