Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960252 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 2b37f129ba63523027ed636f5ccde8db892e5f6bbb7401077378fddf78a7592c). Ok. Summary verified from Touch.pm. Ok. TODO: Correct summary spelling (timestamps → time stamps). TODO: Rephrase description (The following Perl module allows you to → This Perl module allows you to). Nothing follows after the sentence. FIX: Correct license tag (Touch.pm states (GPL+ or Artistic)). There is no XS code, noarch BuildArch is Ok. TODO: Build-require `perl(IO::File)' (Touch.pm:11). TODO: Build-require `perl(File::stat)' (Touch.pm:12). TODO: Build-require `perl(Fcntl)' (Touch.pm:13). FIX: Do not build-require `perl(base)'. It's used nowhere. TODO: You can use simple `perl' instead of `%{__perl}' macro. All tests pass. Ok. $ rpmlint perl-File-Touch.spec ../SRPMS/perl-File-Touch-0.08-2.fc20.src.rpm ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm perl-File-Touch.spec:46: W: macro-in-%changelog %{version} perl-File-Touch.src: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.src: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.src:46: W: macro-in-%changelog %{version} perl-File-Touch.noarch: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.noarch: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps 2 packages and 1 specfiles checked; 0 errors, 6 warnings. FIX: Escape the per-cent character in the changelog with another per-cent character. TODO: Correct the spelling. $ rpm -q -lv -p ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm drwxr-xr-x 2 root root 0 May 9 16:19 /usr/share/doc/perl-File-Touch-0.08 -rw-r--r-- 1 root root 550 Jul 25 2009 /usr/share/doc/perl-File-Touch-0.08/Changes -rw-r--r-- 1 root root 2644 May 9 16:19 /usr/share/man/man3/File::Touch.3pm.gz drwxr-xr-x 2 root root 0 May 9 16:19 /usr/share/perl5/vendor_perl/File -rw-r--r-- 1 root root 5812 Jul 25 2009 /usr/share/perl5/vendor_perl/File/Touch.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(File::stat) 1 perl(IO::File) 1 perl(:MODULE_COMPAT_5.16.3) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm | sort | uniq -c 1 perl(File::Touch) = 0.08 1 perl-File-Touch = 0.08-2.fc20 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm Binary dependencies resolvable. Ok. Package build in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5354528). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6rpr4T1hgq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review