Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952796 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 63a63b6eebb59c941c5394cc087748e9219c57055f8cfc2eaa7c3939a1e67be5). Ok. Patches are good. Ok. Summary verified from README. Ok. Description verified from lib/Spreadsheet/XLSX.pm. Ok. No XS code, noarch BuilArch is Ok. License verified from README and lib/Spreadsheet/XLSX.pm. Ok. FIX: Build-require `perl(ExtUtils::MakeMaker)' (Makefile.PL:2). FIX: Build-require `perl(Data::Dumper)' for running tests (lib/Spreadsheet/XLSX.pm:13). FIX: Build-require `perl(Exporter)' for running tests (lib/Spreadsheet/XLSX/Utility2007.pm:12). FIX: Build-require `perl(Test::More)' for running tests (t/2_____with_chart.t:1). TODO: You can use plain `perl' instead of macro `%{__perl}'. BuildRoot code is for EPEL-5. Ok. TODO: You can replace `PERL_INSTALL_ROOT' with `DESTDIR' argument in %install section. TODO: You can remove explicit %defattr definition in %files sectinos. All tests pass. Ok. $ rpmlint perl-Spreadsheet-XLSX.spec ../SRPMS/perl-Spreadsheet-XLSX-0.13-1.fc20.src.rpm ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm drwxr-xr-x 2 root root 0 May 9 15:52 /usr/share/doc/perl-Spreadsheet-XLSX-0.13 -rw-r--r-- 1 root root 2143 May 16 2010 /usr/share/doc/perl-Spreadsheet-XLSX-0.13/Changes -rw-r--r-- 1 root root 604 Jul 4 2008 /usr/share/doc/perl-Spreadsheet-XLSX-0.13/README -rw-r--r-- 1 root root 3225 May 9 15:52 /usr/share/man/man3/Spreadsheet::XLSX.3pm.gz -rw-r--r-- 1 root root 2070 May 9 15:52 /usr/share/man/man3/Spreadsheet::XLSX::Fmt2007.3pm.gz -rw-r--r-- 1 root root 3297 May 9 15:52 /usr/share/man/man3/Spreadsheet::XLSX::Utility2007.3pm.gz drwxr-xr-x 2 root root 0 May 9 15:52 /usr/share/perl5/vendor_perl/Spreadsheet drwxr-xr-x 2 root root 0 May 9 15:52 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX -rw-r--r-- 1 root root 8422 May 9 15:52 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX.pm -rw-r--r-- 1 root root 5487 May 16 2010 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX/Fmt2007.pm -rw-r--r-- 1 root root 37046 May 16 2010 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX/Utility2007.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm | sort | uniq -c 1 perl >= 0:5.006000 1 perl(Archive::Zip) 1 perl(Data::Dumper) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.3) 1 perl(Spreadsheet::ParseExcel) 1 perl(Spreadsheet::XLSX::Fmt2007) 1 perl(Spreadsheet::XLSX::Utility2007) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm | sort | uniq -c 1 perl(Spreadsheet::XLSX) = 0.13 1 perl-Spreadsheet-XLSX = 0.13-1.fc20 1 perl(Spreadsheet::XLSX::Fmt2007) = 0.13 1 perl(Spreadsheet::XLSX::Utility2007) = 0.13 Binary provides are Ok. Package does not build in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5354415). FIX: Declare all the build-time dependencies. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6u8AYwv9vd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review