Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960515 --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- Please, rename the spec filename to %{name}.spec. While it's not required, it'll be less confusing. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name On the contrary, don't rename upstream tarball. There's no 'perl-' prefix there. Also, your Source0 URL is incorrect because of this. You're missing the MODULE_COMPAT macro. https://fedoraproject.org/wiki/Packaging:Perl?rd=Packaging/Perl#Versioned_MODULE_COMPAT_Requires Your package is also missing a bunch of build-time dependencies: - perl (executed in spec, line 24), recommended - perl(base), required - perl(Carp), required - perl(Exporter), required - perl(LWP::UserAgent), required - perl(strict), recommended - perl(Test::More), required - perl(warnings), recommended The following deps are, even though they're listed in META* files, not used anywhere in the code and should be dropped: - perl(Config::Auto) - perl(LWP) - perl(Test::Simple) - perl(URI) There's no need for %{dist} in %changelog. Not approving at the moment. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xspzoE1slV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review