[Bug 919265] Review Request: bijiben - Simple Note Viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919265

--- Comment #26 from Pierre-Yves Luyten <py@xxxxxxxxx> ---
(In reply to comment #22)

> 2)
> > autoreconf -i -f
> 
> The autoreconf call seems unneeded now that you are no longer patching the
> build system.
> 


ah yes, done.


> 3)
> > %exclude %{_libdir}/%{name}/libgd.la
> 
> Shouldn't be needed any more now that the package is no longer installing
> the libgd shared library.

Yes, no lib is installed, removed.

> 
> 4)
> > %files
> > %doc NEWS AUTHORS COPYING ChangeLog NEWS README
> > %files -f %{name}.lang
> 
> Two issues here: you are repeating the %files section and the NEWS file is
> listed twice.

I can't believe i missed it, thanks.

SPEC: http://py.luyten.fr/Publique/gnome/bjb/381-2/bijiben.spec
SRPM: http://py.luyten.fr/Publique/gnome/bjb/381-2/bijiben-3.8.1-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Br3aZOuP1Y&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]