Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920879 --- Comment #4 from Tanner Doshier <doshitan@xxxxxxxxx> --- (In reply to comment #2) > 1.I think you should use %{name} to replace "tali" as many as possible. A package's name isn't subject to change. I suppose %{name} helps the file be a better template for common stuff, but for specifically installed files (especially for the few in this game), explicitly stating the name seems reasonable to me. > 2.What about adding NEWS file to %doc? We could, but it isn't done for any of the other gnome games nor the old package (though that might not be sufficient justification on its own). > 3.Not familiar with the permission control "%attr(2551, root, games)", any > reason can tell? Tali currently stores it's score files in a system directory, so we add it to the games group and give the group access to read/write the score files. It's a pattern carried over from the old package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nfwa2s4q6f&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review