[Bug 958810] Review Request: gfal2-plugin-xrootd - Provide xrootd support for GFAL2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958810

--- Comment #2 from Adrien Devresse <adev88@xxxxxxxxx> ---
Hi Alej,

Thank you for the review

I updated the src rpm from your comments  : 

Spec URL:
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-plugin-xrootd/gfal2-plugin-xrootd.spec 
SRPM URL:
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-plugin-xrootd/gfal2-plugin-xrootd-0.2.2-2.el5.centos.src.rpm


Problems : 

-> Only packaging related entries should appear. There are entries
    related to upstream.
--> Done


> 	gfal2-devel requires glib2-devel, so this BuildRequires should
    be removed.

--> Corrected

> 	It is manually installed under _docdir

--> All files under _docdir are automatically marked as "documentation" like
with the %doc macro. The usage of the doc macro is not needed in this case.
http://www.redhat.com/archives/rpm-list/2001-September/msg00152.html

> 	Missing make %{?_smp_mflags} in build, or those flags in install

--> Done, add missing make entry

Cheers,
Adrien

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OCmxlf1V48&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]