Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xml-commons-apis12 - JAXP 1.2, DOM 2, SAX 2.0.1, SAX2-ext 1.0 apis https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231263 ------- Additional Comments From mwringe@xxxxxxxxxx 2007-03-07 14:41 EST ------- (In reply to comment #1) > The docs seem to be copied to %{_datadir}/%{name}-%{version} > instead of being copied into %{_datadir}/doc/%{name}-%{version}. > They shouldn't be copied manually; just use %doc in %files section. ok, I changed this to use the %doc section. > rpmlint is complaining about non-standard Groups. The main package should > probably be System/Libraries and the other ones can be Development or something > like that. We have always been told that the rpmlint group warnings should just be ignored. (see https://www.redhat.com/archives/fedora-packaging/2007-February/msg00070.html) The groups have been updated to get rid of this warning though, One other change I made to the spec file, I had the wrong license listed. The package has components under different licenses (Apache, w3c and public domain). These have been listed as "License: Apache Software License/W3C License/Public Domain" in the spec file. rpmlint will complain about this situation. Updated files located here: https://mwringe.108.redhat.com/files/documents/175/272/xml-commons-apis12.spec https://mwringe.108.redhat.com/files/documents/175/271/xml-commons-apis12-1.2.04-0jpp.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review