[Bug 960142] Review Request: rubygem-faker - Easily generate fake data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960142

--- Comment #3 from Josef Stribny <jstribny@xxxxxxxxxx> ---
* run tests properly
  Currently no tests are being run.
  Including rubygem(i18n) as a BuildDependency should make them run.

* comments
  Why is `BuildRequires: rubygem(yaml)` and `ruby -Ilib:test ...` commented
out?
  Either make useful comments or delete them.

* license
  %doc %{gem_instdir}/License.txt should be in the main package.

* rpmlint
  You should have %%gem_dir instead of %gem_dir in the comment so the macro
won't expand.

Please run the test suite with rubygem-i18n and fix the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LebfJ66Wer&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]