[Bug 953783] Review Request: vim-taglist - The "Tag List" plugin is a source code browser plugin for Vim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953783

--- Comment #8 from Robert Kuska <rkuska@xxxxxxxxxx> ---
vim-taglist.noarch: W: invalid-license vim
vim-taglist.noarch: E: script-without-shebang
/usr/share/vim/vimfiles/doc/taglist.txt

- little typo with license name, its Vim I guess
- you should change permissions of .txt file to 644
- you should delete the Buildroot, it is not used anymore, same applies for the
clean section and deleting the buildroot in install section  [1][2]
- you should unify macro using imo, replace your mkdir  with mkdir -p
%{buildroot}%{vimfiles_root}



[1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[2]
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oJFv44qkMt&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]