Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960258 --- Comment #3 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- Ok, next (final?) pre-review: 1. %make_install == make install DESTDIR=%{buildroot} 2. changelog must be in right order (freshest is on the top) 3. Koji builds are welcome 4. Please use unified section split style - or double CR or one. 5. Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz (http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net) As you use hand-made svn snapshot - I can't check it and fedora-review can't download sources. >From other side - main differences between 771 and original 1.3.5 tarball are a) new test cases (that you don't need) and b) small CmakeLists.txt patch. I propose you to use original 1.3.5 tarball and aply patch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYrS9Kiaam&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review