Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960194 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalevlember@xxxxxxxxx --- Comment #5 from Kalev Lember <kalevlember@xxxxxxxxx> --- (In reply to comment #2) > Oh, I forgot: I've never seen %make_install. There is some reference to > %makeinstall in the guidelines but it is discouraged. How different is > %make_install to make install DESTDIR=%{buildroot} ? %make_install is the sane version that we should be using, %makeinstall is the one that's discouraged. You can always check what a macro does by expanding it on the command line: rpm -E %make_install /usr/bin/make install DESTDIR=/home/kalev/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n9oigNG1pL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review